-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate docs into Arabic issue-number #32435 #32513
Conversation
Hi! It is extremely difficult to review 400+ file changes. For translations, you should work on translating one file at a time, get it reviewed by a native Arabic speaker, and then move on to the next document. Translations should also be done manually to ensure nothing gets lost in translation, which can sometimes happen when using machine translation programs/apps. I noticed you opened similar PRs in the Diffusers/Datasets repositories. The same comment here applies to those PRs as well. I'd suggest closing these PRs and then opening just one PR focused on translating one document. Thanks! 🤗 |
Hi @AhmedAlmaghz, thank you for dedicating so much time in translating the docs! It's simply just not feasible for someone to review a PR of this size. For context, the general rule for PRs is that there shouldn't be more than 400 lines of diff for the reviewer. Here there's 61k. You should be able to separate out the file commits into their own PRs, which can then be reviewed. |
@AhmedAlmaghz I will be happy to review small PRs, you did what I procrastinating for a long time. Thank you again for the hard work and great addition to the Arabic community (جزاء الله خيرأ) |
What does this PR do?
Translate docs into Arabic issue-number #32435
@stevhliu and @MKhalusova